Tell an invalid roster apart from an unreachable server #3

Merged

nicolas merged 1 commit from fix/invalid-payload into main

2026-09-09 12:43:34 +00:00

nicolas commented

2026-09-09 12:23:28 +00:00

Owner

Day banner: "Le serveur répond, mais pas avec une feuille de service." with the settings offered.
Connection test decodes the answer rather than merely fetching it, so a wrong address is caught where it is typed.
Tests run a local server serving HTML, a drifted shape and a real roster.

Independent of #2.

🤖 Generated with Claude Code

A 200 that is not a roster — a login page, a web front at the wrong address, a payload whose shape drifted — used to escape the decoder as a generic failure and read exactly like being offline. It is now `ShiftServiceError.Invalid`, carrying the decoder's reason for the logs. - Day banner: "Le serveur répond, mais pas avec une feuille de service." with the settings offered. - Connection test decodes the answer rather than merely fetching it, so a wrong address is caught where it is typed. - Tests run a local server serving HTML, a drifted shape and a real roster. Independent of #2. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nicolas added 1 commit

2026-09-09 12:23:28 +00:00

feat(core): tell an invalid roster apart from an unreachable server 9498d6a76b

A 200 that is not a roster — a login page, a web front at the wrong
address, a payload whose shape drifted — used to escape the decoder as a
generic failure and read exactly like being offline. It is now
ShiftServiceError.Invalid, carrying the decoder's reason for the logs.
The day banner says the server answers but not with a feuille de
service and offers the settings; the connection test decodes the
answer rather than merely fetching it, so a wrong address is caught
where it is typed. Tests run a local server serving HTML, a drifted
shape and a real roster.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

nicolas merged commit 0b2b73c2cf into main

2026-09-09 12:43:34 +00:00

nicolas deleted branch fix/invalid-payload

2026-09-09 12:43:34 +00:00

nicolas referenced this pull request from a commit

2026-09-09 12:43:34 +00:00

Tell an invalid roster apart from an unreachable server (#3)